Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix solaris support #45

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix solaris support #45

merged 1 commit into from
Jan 20, 2022

Conversation

ichizok
Copy link
Contributor

@ichizok ichizok commented Jan 20, 2022

There are some compile errors on OpenIndiana (Golang 1.17).

% go run _example/readline.go
# github.com/mattn/go-tty
./tty_unix.go:40:34: undefined: syscall.SYS_IOCTL
./tty_unix.go:46:34: undefined: syscall.SYS_IOCTL
./tty_unix.go:67:31: undefined: syscall.SYS_IOCTL
./tty_unix.go:78:34: undefined: syscall.SYS_IOCTL

Rewrote syscall callings by using golang.org/x/sys/unix package.

@mattn
Copy link
Owner

mattn commented Jan 20, 2022

LGTM

@mattn mattn merged commit 6774b91 into mattn:master Jan 20, 2022
@mattn
Copy link
Owner

mattn commented Jan 20, 2022

Thank you

@ichizok ichizok deleted the fix/solaris branch January 20, 2022 14:33
This was referenced May 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichizok @mattn